ContainsAll array list issue Java -


so i'm trying use containsall built in list method compare 2 arrays

i used contains method single values , works perfectly, contains doesn't.

i'm making card game i'm checking whether set of cards in set of cards

so:

  if(this.hand.containsall(hand.getcards())){

however statement keeps returning false..

here's constructor

  private arraylist<card> hand;      public hand(arraylist<card> hand) {             this();             this.hand.addall(hand);         }

here's cards method

 public arraylist<card> getcards() {         return this.hand;     }

unsure why code isn't returning true containsall it's fine when done individually, there common concept haven't considered?

any pointers bonus

thank you

edit:

this returns true when used :

works

public boolean hascard(card card){    if (this.hand.contains(card)){        return true;    } }

doesn't

public boolean hascards(hand hand){     if(this.hand.containsall(hand.getcards()){     return true } }

main..

    card 1 = new card(card.rank.ace, card.suit.clubs);             card 2 = new card(card.rank.ace, card.suit.diamonds);             card 3 = new card(card.rank.two, card.suit.spades);             card 4 = new card(card.rank.six, card.suit.randsuit());             card 5 = new card(card.rank.seven, card.suit.randsuit());             arraylist<card> cards = new arraylist<>();             cards.add(one);             cards.add(two);             cards.add(three);             cards.add(four);             cards.add(five);             hand h = new hand(cards);      card ones = new card(card.rank.ace, card.suit.clubs);         card twos = new card(card.rank.ace, card.suit.diamonds);         card threes = new card(card.rank.two, card.suit.spades);         arraylist<card> cards2 = new arraylist<>();  // works h.hascard(five);  // doesn't h.hascards(h2);           cards2.add(ones);         cards2.add(twos);         cards2.add(threes);         hand h2 = new hand(cards2);

try h.hascard(new card(card.rank.ace, card.suit.clubs)). fill return false. h.hascard(one) returns true.

to understand why, try this: one.equals(new card(card.rank.ace, card.suit.clubs). these 2 instances of same card, java has no way of knowing it. 2 different objects.

you added one h hand, so, when looking object, find it. searching object new card(card.rank.ace, card.suit.clubs) fails, because java not know represents same card.

to fix this, have override equals message on card, , make return true objects correspond same card.

your containsall call isn't working same reason: hand contains cards, represented different objects. implementing equals method fix well.


Comments

Post a Comment

Popular posts from this blog

get url and add instance to a model with prefilled foreign key :django admin -

Image
i have page in each contest shown in row. each row contains contest id , link other model names have foreign key contest. news model: class news(models.model): title = models.charfield(max_length=50, null=true) description = models.textfield() time = models.timefield( default= datetime.datetime.now().time()) contest = models.foreignkey(contest) i want use admin adding , changing these models. want when user clicks on 'news' has foreign key contest id=1, shows list of news value foreign key. use {% instance in instances %} <tr class="{% cycle 'row1' 'row2' %}"> <td>{{ instance.title }}</td> <td>{{ instance.starttime }}</td> <td>{{ instance.timespan }}</td> <td>{{ instance.date }}</td> <td><a href="/adm
Read more

css - Make div keyboard-scrollable in jQuery Mobile? -

from can tell, although jquery-mobile-powered pages can contain divs overflow set scroll or auto, , these divs can scrolled one-screen bar or mouse wheel, cannot scrolled using arrow keys, page-up/page-down, or home/end. instead, official "page" div (with data-role="page") absorbs input. perhaps other divs can't acquire focus, i'm not sure. is there way around this? edit: jsfiddle of simple example: https://jsfiddle.net/qogz0shx/ <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://ajax.googleapis.com/ajax/libs/jquerymobile/1.4.5/jquery.mobile.min.js"> </script> <link rel="stylesheet" href="https://code.jquery.com/mobile/1.4.5/jquery.mobile-1.4.5.css"/> <style> #outer { overflow:scroll; height: 50vh; width: 50vw; } #inner { height: 500vh; width: 500vw; } &l
Read more

ruby on rails - Seeing duplicate requests handled with Unicorn -

recently upgraded our ec2 instances c3.large in order boost more unicorn workers handle increased traffic our site. (6xworkers per machine - 2 ec2 instances). when did this, started seeing duplicate records being created! looks somehow, maybe 2 unicorn workers attempting process same request? in nginx logs see 1 [post] request particular rails controller - yet 2 records being created in database. i'm hitting kind of race condition issue - have no idea how debug this. doesn't happen time, when it's frustrating well. noticed 2 database records within 5 seconds of each other. (and yes disable button when user clicks submit button). unicorn 4.8.2 ruby 1.9.3 rails 3.2.14 any great! thanks! although may not fix problem, upgrade ruby 2.0.0. there blog mentioning idea upgrade ruby 2.0.0 if using unicorn. for example: https://www.digitalocean.com/community/articles/how-to-optimize-unicorn-workers-in-a-ruby-on-rails-app specifically: if using ruby 1.9,
Read more