sql - Why are redundant records being inserted with this TSQL Stored Procedure? -


when run portion of stored procedure in linqpad:

create table #temp1 (     memberno varchar(25),     memberitemcode varchar(25),     shortname varchar(25),     itemcode varchar(50),     wvitem varchar(25),     wvitemcode varchar(25),     wvdescription varchar(250),     week1usage varchar(25),     week1price varchar(25) )  insert #temp1 (memberno, memberitemcode, wvitemcode, wvdescription, week1usage, week1price)  select memberno, itemcode, wvitemcode, description, sum(qtyshipped), price invoicedetail  unit=@unit , invoicedate between @begin , @enddate group description, memberno, itemcode, wvitemcode, price  select * #temp1 order memberitemcode;

...i hope for, namely 1 row of data each memberitemcode, qtyshipped summed in column.

however, when populate related table "week2" values, , combine them, this:

create procedure [dbo].[pricevariancetest]     @unit varchar(25),     @begdate datetime,     @enddate datetime    declare @week1end datetime = dateadd(day, 6, @begdate); declare @week2begin datetime = dateadd(day, 7, @begdate);  . . .  create table #temp2 (     memberno varchar(25),     week2usage varchar(25),     week2price varchar(25) )  -- populate week2 vals insert #temp2 (memberno, week2usage, week2price) select memberno, sum(qtyshipped), price invoicedetail  unit=@unit , invoicedate between @week2begin , @enddate group description, memberno, price;  -- have records week1 vals, , week2 vals; combine them third table create table #tempcombined (     memberno varchar(25),     memberitemcode varchar(25),     shortname varchar(25),     itemcode varchar(50),     wvitem varchar(25),     wvitemcode varchar(25),     wvdescription varchar(250),     week1usage varchar(25),     week2usage varchar(25),     usagevariance varchar(25),     week1price varchar(25),     week2price varchar(25),     pricevariance varchar(25),     percentageofpricevariance varchar(25) )  insert #tempcombined (memberno, memberitemcode, wvdescription, week1usage, week1price, week2usage, week2price) select t1.memberno, t1.memberitemcode, t1.wvdescription, t1.week1usage, t1.week1price, t2.week2usage, t2.week2price #temp1 t1 join #temp2 t2 on t1.memberno = t2.memberno

...the result set has gone far south can see kudzu growing on it: 40 milliion records each memberitemcode, instead of summation , grouping working should.

why case when i'm summing/grouping second temp table, too, , combining 2 tables third 1 , returning that?

update

if convert join left join, solves problem i'm bemoaning, week2 values (week2usage , week2price) go silent/dark.

update 2

i hoping justin cave's comment key issue, changed code this:

-- populate week2 vals insert #temp2 (memberno, itemcode, wvdescription, week2usage, week2price) select memberno, itemcode, description, sum(qtyshipped), price invoicedetail  unit=@unit , invoicedate between @week2begin , @enddate group memberno, itemcode, description, price;  -- have records week1 vals, , week2 vals; combine them third table create table #tempcombined (     memberno varchar(25),     memberitemcode varchar(25),     shortname varchar(25),     itemcode varchar(50),     wvitem varchar(25),     wvitemcode varchar(25),     wvdescription varchar(250),     week1usage varchar(25),     week2usage varchar(25),     usagevariance varchar(25),     week1price varchar(25),     week2price varchar(25),     pricevariance varchar(25),     percentageofpricevariance varchar(25) )  insert #tempcombined (memberno, memberitemcode, wvdescription, week1usage, week1price, week2usage, week2price) select t1.memberno, t1.memberitemcode, t1.wvdescription, t1.week1usage, t1.week1price, t2.week2usage, t2.week2price #temp1 t1 left join #temp2 t2 on t1.itemcode = t2.itemcode , t1.memberno = t2.memberno , t1.wvdescription = t2.wvdescription

...but makes no difference - "week2" vals still null.

update 3

by changing join type full outer join, hundreds of records week 1 vals , no week 2 vals, , hundreds of records week 2 vals , no week 1 vals, none have values both weeks.

the count of #tempcombined count of #temp1 , #temp2 combined (iow, piled together, instead of merged).

update 4

i won't able test until monday, i'm thinking maybe work:

insert temp1 (memberitemcode, week1usage, week1price) select memberitemcode, sum(qtyshipped), price invoicedetail  unit=@unit , invoicedate between @begdate , @week1end group memberitemcode, price  insert temp2 (memberitemcode, week2usage, week2price) select memberitemcode, sum(qtyshipped), price invoicedetail  unit=@unit , invoicedate between @week2begin , @enddate group memberitemcode, price  insert temp3 (memberitemcode, week1usage, week1price, week2usage, week2price) select t1.memberitemcode, t1.week1usage, t1.week1price, t2.week2usage, t2.week2price temp1 t1 left join temp2 t2 on t1.memberitemcode = t2.memberitemcode


Comments

Post a Comment

Popular posts from this blog

get url and add instance to a model with prefilled foreign key :django admin -

Image
i have page in each contest shown in row. each row contains contest id , link other model names have foreign key contest. news model: class news(models.model): title = models.charfield(max_length=50, null=true) description = models.textfield() time = models.timefield( default= datetime.datetime.now().time()) contest = models.foreignkey(contest) i want use admin adding , changing these models. want when user clicks on 'news' has foreign key contest id=1, shows list of news value foreign key. use {% instance in instances %} <tr class="{% cycle 'row1' 'row2' %}"> <td>{{ instance.title }}</td> <td>{{ instance.starttime }}</td> <td>{{ instance.timespan }}</td> <td>{{ instance.date }}</td> <td><a href="/adm...
Read more

css - Make div keyboard-scrollable in jQuery Mobile? -

from can tell, although jquery-mobile-powered pages can contain divs overflow set scroll or auto, , these divs can scrolled one-screen bar or mouse wheel, cannot scrolled using arrow keys, page-up/page-down, or home/end. instead, official "page" div (with data-role="page") absorbs input. perhaps other divs can't acquire focus, i'm not sure. is there way around this? edit: jsfiddle of simple example: https://jsfiddle.net/qogz0shx/ <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://ajax.googleapis.com/ajax/libs/jquerymobile/1.4.5/jquery.mobile.min.js"> </script> <link rel="stylesheet" href="https://code.jquery.com/mobile/1.4.5/jquery.mobile-1.4.5.css"/> <style> #outer { overflow:scroll; height: 50vh; width: 50vw; } #inner { height: 500vh; width: 500vw; } ...
Read more

ruby on rails - Seeing duplicate requests handled with Unicorn -

recently upgraded our ec2 instances c3.large in order boost more unicorn workers handle increased traffic our site. (6xworkers per machine - 2 ec2 instances). when did this, started seeing duplicate records being created! looks somehow, maybe 2 unicorn workers attempting process same request? in nginx logs see 1 [post] request particular rails controller - yet 2 records being created in database. i'm hitting kind of race condition issue - have no idea how debug this. doesn't happen time, when it's frustrating well. noticed 2 database records within 5 seconds of each other. (and yes disable button when user clicks submit button). unicorn 4.8.2 ruby 1.9.3 rails 3.2.14 any great! thanks! although may not fix problem, upgrade ruby 2.0.0. there blog mentioning idea upgrade ruby 2.0.0 if using unicorn. for example: https://www.digitalocean.com/community/articles/how-to-optimize-unicorn-workers-in-a-ruby-on-rails-app specifically: if using ruby 1.9, ...
Read more