arrays - Optimum Way To Write Long Javascript Variables containing HTML -


hi guys i'm working on web app outputs heap of html , objects onto html page via javascript.

its looking quite messy , made me wonder - optimum way write , why.

this code

var html_content = '';      html_content += "<div class='body-content'>";         html_content += "<h1>" + wowarr.name +"</h1><br />" + "<h2> arena titles (account wide)</h2>" + achievementz.join('<br />') + "<br /><br />"                   + "<h2>highest arena ratings</h2>"                   + "<span style='color: #ffffff;'>"+rating2v2.name+"</span>" + ": " + rating2v2.quantity + "<br/>" + "last reached on: " + gethighestdate(rating2v2) + "<br/><br/>"                  + "<span style='color: #ffffff;'>"+rating3v3.name+"</span>" + ": " + rating3v3.quantity + "<br/>" + "last reached on: " + gethighestdate(rating3v3) + "<br/><br/>"                  + "<span style='color: #ffffff;'>"+rating5v5.name+"</span>" + ": " + rating5v5.quantity + "<br/>" + "last reached on: " + gethighestdate(rating5v5) + "<br/><br/>"                  + "<h2>current arena rating</h2>2v2 rating: " + wow2s + '<br />' + "3v3 rating: " + wow3s + '<br />' + "5v5 rating: " + wow5s + '<br /><br />'                    + "<h2>current rbg rating</h2>rbg rating: " + wowrbgs + '<br /><br />'                   + '<input type="button" class="homebtn" name="startgame" value="new" onclick="reloadw();">';      html_content += "</div>";      $('.main-content').html(html_content);

to me looks theres better way don't have slightest start.

any direction or appreciated!

es6 template syntax other answer neat, , useful in cases.

however, looking lightweight templating engine.

let me give few reasons use template engine instead of concatenating strings:

  • it cleanest way solve problem

  • you can separate templates / data , rendering code, it's easier maintain

  • your security free: {{variables}} automatically escaped (see how escaped "name" variable in example below)

  • since have achievementz.join(), assume wanted loop through achievements display , templates become more complex loops, conditional statements etc... templating engine can handle that: loops, conditions , function calls

  • no need worry compatibility, can use method pretty anywhere

  • it flexible , if want can automatically compile templates js variables, embed templates .js files , keep advantages above

here full rewrite of code using mustache templating engine (mustache.js) :

<!doctype html>  <head>  </head>  <body>    <div id="main-content"></div>  </body>    <!-- here template -->  <script id="template" type="x-tmpl-mustache">         <div class='body-content'>              <h1>{{ name }}</h1><br />              <h2> arena titles (account wide)</h2>               {{#achievementz}}                 {{.}}<br/>               {{/achievementz}}              <br/>              <h2>highest arena ratings</h2>              <span style='color: #000;'> {{ rating2v2.name }}</span>: {{ rating2v2.quantity }}<br/>last reached on: {{ rating2v2.highestdate }} <br/><br/>              <span style='color: #000;'>{{ rating3v3.name }}</span>: {{ rating3v3.quantity }}<br/>last reached on: {{ rating3v3.highestdate }}<br/><br/>              <span style='color: #000;'>{{ rating5v5.name }}</span>: {{ rating5v5.quantity }}<br/>last reached on: {{ rating5v5.highestdate }}<br/><br/>              <h2>current arena rating</h2>2v2 rating: {{ wow2s }}<br /> 3v3 rating: {{ wow3s }}<br /> 5v5 rating: {{ wow5s }}<br /><br />              <h2>current rbg rating</h2>rbg rating: {{ wowrbgs }}<br /><br />              <input type="button" class="homebtn" name="startgame" value="new" onclick="reloadw();">          </div>  </script>    <!-- templating engine -->  <script src="https://cdnjs.cloudflare.com/ajax/libs/mustache.js/2.2.1/mustache.min.js"></script>    <!-- usage -->  <script>      var gethighestdate = function() {      var date = new date();      return date.getfullyear();    };      // data    var view = {      name: "super <b>joe</b>",      achievementz: [        "achievement 1",        "achievement 2",        "achievement 3",        "achievement 4"      ],      rating2v2: {        name: "mr red",        quantity: 42,        highestdate: gethighestdate      },      rating3v3: {        name: "mr orange",        quantity: 69,        highestdate: gethighestdate      },      rating5v5: {        name: "mr black",        quantity: 666,        highestdate: gethighestdate      },      wow2s: "wow2s text...",      wow3s: "wow3s text...",      wow5s: "wow5s text...",      wowrbgs: "wow rgb..."    };      // rendering code    document.getelementbyid("main-content").innerhtml = mustache.render(document.getelementbyid("template").text, view);    </script>


Comments

Post a Comment

Popular posts from this blog

get url and add instance to a model with prefilled foreign key :django admin -

Image
i have page in each contest shown in row. each row contains contest id , link other model names have foreign key contest. news model: class news(models.model): title = models.charfield(max_length=50, null=true) description = models.textfield() time = models.timefield( default= datetime.datetime.now().time()) contest = models.foreignkey(contest) i want use admin adding , changing these models. want when user clicks on 'news' has foreign key contest id=1, shows list of news value foreign key. use {% instance in instances %} <tr class="{% cycle 'row1' 'row2' %}"> <td>{{ instance.title }}</td> <td>{{ instance.starttime }}</td> <td>{{ instance.timespan }}</td> <td>{{ instance.date }}</td> <td><a href="/adm...
Read more

css - Make div keyboard-scrollable in jQuery Mobile? -

from can tell, although jquery-mobile-powered pages can contain divs overflow set scroll or auto, , these divs can scrolled one-screen bar or mouse wheel, cannot scrolled using arrow keys, page-up/page-down, or home/end. instead, official "page" div (with data-role="page") absorbs input. perhaps other divs can't acquire focus, i'm not sure. is there way around this? edit: jsfiddle of simple example: https://jsfiddle.net/qogz0shx/ <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://ajax.googleapis.com/ajax/libs/jquerymobile/1.4.5/jquery.mobile.min.js"> </script> <link rel="stylesheet" href="https://code.jquery.com/mobile/1.4.5/jquery.mobile-1.4.5.css"/> <style> #outer { overflow:scroll; height: 50vh; width: 50vw; } #inner { height: 500vh; width: 500vw; } ...
Read more

ruby on rails - Seeing duplicate requests handled with Unicorn -

recently upgraded our ec2 instances c3.large in order boost more unicorn workers handle increased traffic our site. (6xworkers per machine - 2 ec2 instances). when did this, started seeing duplicate records being created! looks somehow, maybe 2 unicorn workers attempting process same request? in nginx logs see 1 [post] request particular rails controller - yet 2 records being created in database. i'm hitting kind of race condition issue - have no idea how debug this. doesn't happen time, when it's frustrating well. noticed 2 database records within 5 seconds of each other. (and yes disable button when user clicks submit button). unicorn 4.8.2 ruby 1.9.3 rails 3.2.14 any great! thanks! although may not fix problem, upgrade ruby 2.0.0. there blog mentioning idea upgrade ruby 2.0.0 if using unicorn. for example: https://www.digitalocean.com/community/articles/how-to-optimize-unicorn-workers-in-a-ruby-on-rails-app specifically: if using ruby 1.9, ...
Read more