javascript - $window .on("scroll") working only in last directive it's called on -


i'm trying create simple directive sets or removes classes when scrolling near element. i'm using callback scroll event on $window, problem it's working last directive only.

plunker

html

<html ng-app="myapp">    <head>     <link rel="stylesheet" href="style.css">     <script src="//code.jquery.com/jquery-1.12.0.min.js"></script>     <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.5/angular.min.js"></script>     <script src="script.js"></script>   </head>    <body>     <div class="box hidden" on-scroll-class="{add: 'large', remove: 'hidden'}"></div>     <div class="box hidden" on-scroll-class="{add: 'large', remove: 'hidden'}"></div>     <div class="box hidden" on-scroll-class="{add: 'large', remove: 'hidden'}"></div>   </body>  </html>

js

var app = angular.module("myapp", []); app.directive("onscrollclass", ["$window", function ($window) {     return {       restrict: "a",       scope: {         onscrollclass: "@",         onscrollclassreverse: "@",         onscrolloffset: "@"       },       link: function(scope, element, attrs) {               var reverse = angular.isdefined(scope.onscrollclassreverse) ?                 scope.onscrollclassreverse : false;                var offset = angular.isdefined(scope.onscrolloffset) ?                 scope.onscrolloffset : 150;                var classtoaddobj = scope.$eval(scope.onscrollclass);               var classtoadd;               var classtoremove = null;                if (angular.isobject(classtoaddobj)) {                 classtoadd = classtoaddobj.add;                 classtoremove = classtoaddobj.remove;               } else {                 classtoadd = classtoaddobj;               }                $element = $(element);               $($window).on("scroll", function() {                   console.log($element);                   console.log($element.offset().top);                   if (this.pageyoffset >= $element.offset().top - offset) {                       $element.addclass(classtoadd);                       $element.removeclass(classtoremove);                    } else if (reverse) {                       $element.addclass(classtoremove);                       $element.removeclass(classtoadd);                   }                 });            }       } }]);

css

body {   height: 2000px; }  .hidden {   opacity: .3; }  .large {   transform: scale(1.2); }  .box {   background-color: tomato;   width: 200px;   height: 200px;   margin: 50px auto;   transition: .5s ease;  }

it has nothing angular.

you setting variable $element without declaring variable. due javascript prototypal inheritance, try find variable in prototype chain. , in case won't find it, treat global variable.

thats why last directive works you, it's overriding $element variable each time.

just add var before $element, , remember declare variable using var keyword (or let (es 2015) better).


Comments

Post a Comment

Popular posts from this blog

get url and add instance to a model with prefilled foreign key :django admin -

Image
i have page in each contest shown in row. each row contains contest id , link other model names have foreign key contest. news model: class news(models.model): title = models.charfield(max_length=50, null=true) description = models.textfield() time = models.timefield( default= datetime.datetime.now().time()) contest = models.foreignkey(contest) i want use admin adding , changing these models. want when user clicks on 'news' has foreign key contest id=1, shows list of news value foreign key. use {% instance in instances %} <tr class="{% cycle 'row1' 'row2' %}"> <td>{{ instance.title }}</td> <td>{{ instance.starttime }}</td> <td>{{ instance.timespan }}</td> <td>{{ instance.date }}</td> <td><a href="/adm...
Read more

android - Keyboard hides my half of edit-text and button below it even in scroll view -

i having trouble keyboard covers edit-text , half of button in scroll view. here's layout , please tell me how should resolve problem. many questions on topic none of them s working me. <?xml version="1.0" encoding="utf-8"?> <linearlayout xmlns:android="http://schemas.android.com/apk/res/android" android:layout_width="match_parent" android:background="@drawable/bg" android:layout_height="match_parent"> <scrollview android:layout_width="match_parent" android:fillviewport="true" android:layout_height="match_parent"> <relativelayout android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical"> <linearlayout android:layout_width="match_parent" android:layout_height="w...
Read more

css - Make div keyboard-scrollable in jQuery Mobile? -

from can tell, although jquery-mobile-powered pages can contain divs overflow set scroll or auto, , these divs can scrolled one-screen bar or mouse wheel, cannot scrolled using arrow keys, page-up/page-down, or home/end. instead, official "page" div (with data-role="page") absorbs input. perhaps other divs can't acquire focus, i'm not sure. is there way around this? edit: jsfiddle of simple example: https://jsfiddle.net/qogz0shx/ <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://ajax.googleapis.com/ajax/libs/jquerymobile/1.4.5/jquery.mobile.min.js"> </script> <link rel="stylesheet" href="https://code.jquery.com/mobile/1.4.5/jquery.mobile-1.4.5.css"/> <style> #outer { overflow:scroll; height: 50vh; width: 50vw; } #inner { height: 500vh; width: 500vw; } ...
Read more