excel - Code meant to copy rows from one sheet to another if there are specific strings in 2 columns keeps crashing -


whenever run code crashes. please help!

this code supposed do. unknown amount of filled rows, if column g of worksheet "current pm" contains either "as-001", "ee-001", "mm-001", "os-001", "co-001", "do-001", "fo-001", "fd-001", "to-001", "ip-001" , column h contains "pdr" copy row "current pm" sheet "print_current pms" sheet. 

sub sort4printing()  dim integer, j integer  = 2: j = 2  while isempty(worksheets("current pm").cells(i, 1)) = false  if worksheets("current pm").cells(i, 8) = "pdr"  if worksheets("current pm").cells(i, 7) = "as-001" or worksheets("current pm").cells(i, 7) = "ee-001" or worksheets("current pm").cells(i, 7) = "mm-001" or worksheets("current pm").cells(i, 7) = "os-001" or worksheets("current pm").cells(i, 7) = "fo-001" or worksheets("current pm").cells(i, 7) = "fd-001" or worksheets("current pm").cells(i, 7) = "to-001" or worksheets("current pm").cells(i, 7) = "ip-001"  worksheets("print_current pms").cells(j, 1) = worksheets("current pm").cells(i, 1) worksheets("print_current pms").cells(j, 2) = worksheets("current pm").cells(i, 2) worksheets("print_current pms").cells(j, 3) = worksheets("current pm").cells(i, 12) worksheets("print_current pms").cells(j, 4) = worksheets("current pm").cells(i, 4) worksheets("print_current pms").cells(j, 5) = worksheets("current pm").cells(i, 5) worksheets("print_current pms").cells(j, 6) = worksheets("current pm").cells(i, 6) worksheets("print_current pms").cells(j, 7) = worksheets("current pm").cells(i, 7) worksheets("print_current pms").cells(j, 8) = worksheets("current pm").cells(i, 8) worksheets("print_current pms").cells(j, 9) = worksheets("current pm").cells(i, 10)      i=i+1: j=j+1 end if end if wend  end sub

while, don't know exactly why crashes, can offer clean-up , techniques cut down on processing of code.

  1. no need iterate through 2 variables, since both same counter
  2. dimension counting variable type long, if there more 32,767 rows integer variable fall due it's byte limitation.
  3. using with block when working objects, instead of referencing object
  4. using select case statement multiple conditions on same object (i believe) take less processing multiple if or conditions. it's a lot more reader friendly.

see refactored code:

sub sort4printing()  dim long  = 2  worksheets("current pm")      while not isempty(.cells(i, 1))          if .cells(i, 8) = "pdr"              select case .cells(i, 7)                  case = "as-001", "ee-001", "mm-001", "os-001", "fo-001", "fd-001", "to-001", "ip-001"                      worksheets("print_current pms").cells(i, 1) = .cells(i, 1)                     worksheets("print_current pms").cells(i, 2) = .cells(i, 2)                     worksheets("print_current pms").cells(i, 3) = .cells(i, 12)                     worksheets("print_current pms").cells(i, 4) = .cells(i, 4)                     worksheets("print_current pms").cells(i, 5) = .cells(i, 5)                     worksheets("print_current pms").cells(i, 6) = .cells(i, 6)                     worksheets("print_current pms").cells(i, 7) = .cells(i, 7)                     worksheets("print_current pms").cells(i, 8) = .cells(i, 8)                     worksheets("print_current pms").cells(i, 9) = .cells(i, 10)              end select          end if          = + 1      wend  end  end sub

Comments

Post a Comment

Popular posts from this blog

get url and add instance to a model with prefilled foreign key :django admin -

Image
i have page in each contest shown in row. each row contains contest id , link other model names have foreign key contest. news model: class news(models.model): title = models.charfield(max_length=50, null=true) description = models.textfield() time = models.timefield( default= datetime.datetime.now().time()) contest = models.foreignkey(contest) i want use admin adding , changing these models. want when user clicks on 'news' has foreign key contest id=1, shows list of news value foreign key. use {% instance in instances %} <tr class="{% cycle 'row1' 'row2' %}"> <td>{{ instance.title }}</td> <td>{{ instance.starttime }}</td> <td>{{ instance.timespan }}</td> <td>{{ instance.date }}</td> <td><a href="/adm
Read more

css - Make div keyboard-scrollable in jQuery Mobile? -

from can tell, although jquery-mobile-powered pages can contain divs overflow set scroll or auto, , these divs can scrolled one-screen bar or mouse wheel, cannot scrolled using arrow keys, page-up/page-down, or home/end. instead, official "page" div (with data-role="page") absorbs input. perhaps other divs can't acquire focus, i'm not sure. is there way around this? edit: jsfiddle of simple example: https://jsfiddle.net/qogz0shx/ <script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.4/jquery.min.js"></script> <script src="https://ajax.googleapis.com/ajax/libs/jquerymobile/1.4.5/jquery.mobile.min.js"> </script> <link rel="stylesheet" href="https://code.jquery.com/mobile/1.4.5/jquery.mobile-1.4.5.css"/> <style> #outer { overflow:scroll; height: 50vh; width: 50vw; } #inner { height: 500vh; width: 500vw; } &l
Read more

ruby on rails - Seeing duplicate requests handled with Unicorn -

recently upgraded our ec2 instances c3.large in order boost more unicorn workers handle increased traffic our site. (6xworkers per machine - 2 ec2 instances). when did this, started seeing duplicate records being created! looks somehow, maybe 2 unicorn workers attempting process same request? in nginx logs see 1 [post] request particular rails controller - yet 2 records being created in database. i'm hitting kind of race condition issue - have no idea how debug this. doesn't happen time, when it's frustrating well. noticed 2 database records within 5 seconds of each other. (and yes disable button when user clicks submit button). unicorn 4.8.2 ruby 1.9.3 rails 3.2.14 any great! thanks! although may not fix problem, upgrade ruby 2.0.0. there blog mentioning idea upgrade ruby 2.0.0 if using unicorn. for example: https://www.digitalocean.com/community/articles/how-to-optimize-unicorn-workers-in-a-ruby-on-rails-app specifically: if using ruby 1.9,
Read more